Skip to content

examples: replace structopt with clap#1007

Merged
ehuss merged 1 commit into
rust-lang:masterfrom
tamird:clap
Mar 14, 2024
Merged

examples: replace structopt with clap#1007
ehuss merged 1 commit into
rust-lang:masterfrom
tamird:clap

Conversation

@tamird

@tamird tamird commented Jan 7, 2024

Copy link
Copy Markdown
Contributor

See TeXitoi/structopt#525.

Currently git2 is the most downloaded dependent of structopt:
https://crates.io/crates/structopt/reverse_dependencies.

@tamird

tamird commented Jan 11, 2024

Copy link
Copy Markdown
Contributor Author

@ehuss this is green now that you merged #1008. Could you take a look please?

@tamird

tamird commented Jan 15, 2024

Copy link
Copy Markdown
Contributor Author

@ehuss friendly ping!

@tamird

tamird commented Feb 22, 2024

Copy link
Copy Markdown
Contributor Author

@ehuss ping.

@tamird

tamird commented Mar 14, 2024

Copy link
Copy Markdown
Contributor Author

@epage can you merge it?

@ehuss ehuss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss added this pull request to the merge queue Mar 14, 2024
Merged via the queue into rust-lang:master with commit a75e007 Mar 14, 2024
@tamird tamird deleted the clap branch March 14, 2024 17:54
@tamird

tamird commented Mar 14, 2024

Copy link
Copy Markdown
Contributor Author

Thanks! Would it be possible to cut a patch release?

@ehuss

ehuss commented Mar 14, 2024

Copy link
Copy Markdown
Contributor

Can you say more about what you are looking for in a new release? I don't expect people are using the examples directly, and it shouldn't have any impact on the git2-rs library.

@tamird

tamird commented Mar 14, 2024

Copy link
Copy Markdown
Contributor Author

Ah, it's a dev dependency. My mistake. The only thing a release would do is remove git2-rs from the rankings.

@rpelliard rpelliard mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants